Bash script problem

JohnRoe

I want to encode all files in a folder from mkv to mp4. I got a bash script:

http://pastebin.com/mfmYU34c

in the folder,the filename is like this :

[A-Destiny] Toriko - 51 (848x480 h264 AAC) [B7B209E9].mkv

when I execute the script, it show errors..
what can I see, when it scan the folder, the filename will be separated.example:

[A-Destiny] Toriko - 51 (848x480 h264 AAC) [B7B209E9].mkv

wll be:

[A-Destiny]

Toriko

51

848x480

h264

AAC

[B7B209E9]

the problem is, why dont it detect the filename as "[A-Destiny] Toriko - 51 (848x480 h264 AAC) [B7B209E9]"

black

You need to setup your $IFS variable.

Here's an example:

#!/bin/bash
OIFS=$IFS; #save your current IFS variable
IFS=$'\n'; #change IFS to new line char
for file in `ls -1 test`
do
        echo "file -> $file";
done
IFS=$OFIS; #restore your IFS variable

JohnRoe

thanks

JohnRoe

hey @black, I found another solution.. just add couple quotes
btw, I got another problem..

it is successfully by doing echo..
but, when I use it in HandBrakeCLI command, it show:

line 11: 22384 Segmentation fault $HANDBRAKE_CLI -i "$SRC"/"$FILE" -o $DEST/$filename.$DEST_EXT

black

That's probably your $HANDBRAKE_CLI or improperly passing arguments to the program.

awson

for f in *.mkv; do avconv -i "$f" -codec copy "$f".mp4; done

JohnRoe

I tried put "" at $DEST.. suddenly the error gone
thanks all

Droidzone

@awson said:
for f in *.mkv; do avconv -i "$f" -codec copy "$f".mp4; done

What about mkv->avi

awson

@joelgm said:
What about mkv->avi

https://libav.org/avconv.html